Re: [PATCH v7 03/20] x86/virt/tdx: Disable TDX if X2APIC is not enabled

From: Dave Hansen
Date: Mon Nov 21 2022 - 19:44:59 EST


On 11/21/22 16:30, Huang, Kai wrote:
>
> How about still having a patch to make INTEL_TDX_HOST depend on X86_X2APIC but
> with something below in the changelog?
>
> "
> TDX capable platforms are locked to X2APIC mode and cannot fall back to the
> legacy xAPIC mode when TDX is enabled by the BIOS. It doesn't make sense to
> turn on INTEL_TDX_HOST while X86_X2APIC is not enabled. Make INTEL_TDX_HOST
> depend on X86_X2APIC.

That's fine and it makes logical sense as a dependency. TDX host
support requires x2APIC. Period.