Re: [PATCH v7 01/20] x86/tdx: Define TDX supported page sizes as macros

From: Huang, Kai
Date: Mon Nov 21 2022 - 19:01:37 EST


On Mon, 2022-11-21 at 15:48 -0800, Hansen, Dave wrote:
> On 11/20/22 16:26, Kai Huang wrote:
> > +/*
> > + * TDX supported page sizes (4K/2M/1G).
> > + *
> > + * Those values are part of the TDX module ABI. Do not change them.
> > + */
> > +#define TDX_PS_4K 0
> > +#define TDX_PS_2M 1
> > +#define TDX_PS_1G 2
>
> That comment can just be:
>
> /* TDX supported page sizes from the TDX module ABI. */
>
> I think folks understand that the kernel can't willy nilly change ABI
> values.

Thanks. Will do.