Re: [PATCH] netfilter: nf_flow_table: add missing locking

From: Felix Fietkau
Date: Mon Nov 21 2022 - 17:30:35 EST


On 21.11.22 21:35, Jakub Kicinski wrote:
On Mon, 21 Nov 2022 21:08:12 +0100 Felix Fietkau wrote:
> Could you also add a Fixes: tag ?
I don't know which commit to use for that tag.

The oldest upstream commit where the problem you're solving
can trigger?
I know, but I'm having a hard time figuring that out. The initial
version of that file came without locking. Later on some locking was
added for supporting an extra API for registering to flow table events,
but it didn't cover the cases that I'm fixing.

My guess is that the locking should have been present from the start, so:

Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")

- Felix