Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings

From: Andrew Morton
Date: Mon Nov 21 2022 - 16:33:41 EST


On Mon, 21 Nov 2022 09:05:43 +0100 David Hildenbrand <david@xxxxxxxxxx> wrote:

> >> MikeK do you have test cases?
> >
> > Sorry, I do not have any test cases.
> >
> > I can ask one of our product groups about their usage. But, that would
> > certainly not be a comprehensive view.
>
> With
>
> https://lkml.kernel.org/r/20221116102659.70287-1-david@xxxxxxxxxx
>
> on it's way, the RDMA concern should be gone, hopefully.
>
> @Andrew, can you queue this one? Thanks.

This is all a little tricky.

It's not good that 6.0 and earlier permit unprivileged userspace to
trigger a WARN. But we cannot backport this fix into earlier kernels
because it requires the series "mm/gup: remove FOLL_FORCE usage from
drivers (reliable R/O long-term pinning)".

Is it possible to come up with a fix for 6.1 and earlier which won't
break RDMA?