Re: [PATCH v2 1/2] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file

From: Krzysztof Kozlowski
Date: Mon Nov 21 2022 - 09:12:23 EST


On 21/11/2022 13:35, Gerald Loacker wrote:
> Add bindings for TI TMAG5273.
>
> Signed-off-by: Gerald Loacker <gerald.loacker@xxxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Removed nodename
> - Changed angle-enable to angle-measurement and used strings
> - Added interrupts
> - Removed vcc-supply from required properties
> - Changed i2c-0 to i2c in examples
> .../iio/magnetometer/ti,tmag5273.yaml | 75 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/ti,tmag5273.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ti,tmag5273.yaml b/Documentation/devicetree/bindings/iio/magnetometer/ti,tmag5273.yaml
> new file mode 100644
> index 000000000000..b2ecd7054a34
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/ti,tmag5273.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/ti,tmag5273.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TMAG5273 Low-Power Linear 3D Hall-Effect Sensor
> +
> +maintainers:
> + - Gerald Loacker <gerald.loacker@xxxxxxxxxxxxxx>
> +
> +description:
> + The TI TMAG5273 is a low-power linear 3D Hall-effect sensor. This device
> + integrates three independent Hall-effect sensors in the X, Y, and Z axes.
> + The device has an integrated temperature sensor available. The TMAG5273
> + can be configured through the I2C interface to enable any combination of
> + magnetic axes and temperature measurements. An integrated angle calculation
> + engine (CORDIC) provides full 360° angular position information for both
> + on-axis and off-axis angle measurement topologies. The angle calculation is
> + performed using two user-selected magnetic axes.
> +
> +properties:
> + compatible:
> + const: ti,tmag5273
> +
> + reg:
> + maxItems: 1
> +
> + "#io-channel-cells":
> + const: 1
> +
> + ti,angle-measurement:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Enables angle measurement in the selected plane.
> + If not specified, "x-y" will be anables as default.
> + enum:
> + - "off"
> + - "x-y"
> + - "y-z"
> + - "x-z"

Drop quotes from all these.

With this:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof