Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

From: Linus Walleij
Date: Mon Nov 21 2022 - 08:57:27 EST


On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:

> I can think of a couple of hacky ways to force use of 43596 fw, but I
> don't think any would be really upstreamable..

If it is only known to affect the Sony Xperias mentioned then
a thing such as:

if (of_machine_is_compatible("sony,xyz") ||
of_machine_is_compatible("sony,zzz")... ) {
// Enforce FW version
}

would be completely acceptable in my book. It hammers the
problem from the top instead of trying to figure out itsy witsy
details about firmware revisions.

Yours,
Linus Walleij