Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject *

From: Nikolay Aleksandrov
Date: Mon Nov 21 2022 - 05:53:37 EST


On 21/11/2022 11:46, Greg Kroah-Hartman wrote:
> The call, kobject_get_ownership(), does not modify the kobject passed
> into it, so make it const. This propagates down into the kobj_type
> function callbacks so make the kobject passed into them also const,
> ensuring that nothing in the kobject is being changed here.
>
> This helps make it more obvious what calls and callbacks do, and do not,
> modify structures passed to them.
>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> Cc: Anna Schumaker <anna@xxxxxxxxxx>
> Cc: Roopa Prabhu <roopa@xxxxxxxxxx>
> Cc: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: Chuck Lever <chuck.lever@xxxxxxxxxx>
> Cc: Jeff Layton <jlayton@xxxxxxxxxx>
> Cc: linux-nfs@xxxxxxxxxxxxxxx
> Cc: bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/base/class.c | 2 +-
> drivers/base/core.c | 8 ++++----
> fs/nfs/sysfs.c | 4 ++--
> include/linux/kobject.h | 8 ++++----
> lib/kobject.c | 4 ++--
> net/bridge/br_if.c | 2 +-
> net/core/net-sysfs.c | 8 ++++----
> net/sunrpc/sysfs.c | 8 ++++----
> 8 files changed, 22 insertions(+), 22 deletions(-)
>

For the bridge:
Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>