Re: [PATCH 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards

[Rajendra Nayak]

On 11/18/2022 7:45 PM, Krzysztof Kozlowski wrote:
> On 18/11/2022 15:13, Krzysztof Kozlowski wrote:
> > On 18/11/2022 08:30, Rajendra Nayak wrote:
> > > Add compatibles for the Pro SKU of the sc7280 CRD boards
> > >
> > > Signed-off-by: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> > > ---
> > >   Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > index 463509f0f23a..2550ab251f7b 100644
> > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > @@ -613,6 +613,11 @@ properties:
> > >             - const: google,hoglin
> > >             - const: qcom,sc7280
> > >   
> > > +      - description: Qualcomm Technologies, Inc. sc7280 CRD Pro platform (newest rev)
> >
> > Such entry is already documented. I think this is not based on recent
> > kernel.
>
> My bad, I missed this is a Pro. Why it is not part of compatible? What
> is the difference between hoglin and CRD Pro?
>
> You have plenty of space in commit msg to explain this.

Sent a v2 adding the details on the difference captured in the commit log.

> Best regards,
> Krzysztof