Re: [PATCH v6 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

From: Rob Herring
Date: Sun Nov 20 2022 - 12:05:19 EST


On Sun, Nov 20, 2022 at 07:13:31AM -0800, Guenter Roeck wrote:
> On Wed, Nov 16, 2022 at 10:36:13PM +0100, Naresh Solanki wrote:
> > Add common fan properties bindings to a schema.
> >
> > Bindings for fan controllers can reference the common schema for the
> > fan
> >
> > child nodes:
> >
> > patternProperties:
> > "^fan@[0-2]":
> > type: object
> > $ref: fan-common.yaml#
> >
> > Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/hwmon/fan-common.yaml | 42 +++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > new file mode 100644
> > index 000000000000..1954882eed77
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Common fan properties
> > +
> > +maintainers:
> > + - Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> > +
> > +properties:
> > + max-rpm:
> > + description:
> > + Max RPM supported by fan.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pulses-per-revolution:
> > + description:
> > + The number of pulse from fan sensor per revolution.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + target-rpm:
> > + description:
> > + Target RPM the fan should be configured during driver probe.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pwms:
> > + description:
> > + PWM provider.
> > +
> > + label:
> > + description:
> > + Optional fan label
> > +
> > + fan-supply:
> > + description:
> > + Power supply for fan.
> > +
>
> I still think that at least min-rpm should be added. It is just as common
> as max-rpm.

Or a table if the response is not linear like LEDs/backlights? Though if
there's a tach, that wouldn't be necessary.

Rob