Re: [PATCH v2 2/3] arm64: dts: qcom: msm8916-acer-a1-724: Add initial device tree

From: Krzysztof Kozlowski
Date: Sun Nov 20 2022 - 05:51:08 EST


On 19/11/2022 21:46, Lin, Meng-Bo wrote:
> Acer Iconia Talk S A1-724 is a tablet using the MSM8916 SoC released
> in 2014.
>
> Note: The original firmware from Acer can only boot 32-bit kernels.
> To boot arm64 kernels it is necessary to flash 64-bit TZ/HYP firmware
> with EDL, e.g. taken from the DragonBoard 410c. This works because Acer
> didn't set up (firmware) secure boot.
>
> Add a device tree for with initial support for:

Thank you for your patch. There is something to discuss/improve.

> +
> +/ {
> + model = "Acer Iconia Talk S A1-724";
> + compatible = "acer,a1-724", "qcom,msm8916";
> + chassis-type = "tablet";
> +
> + aliases {
> + serial0 = &blsp1_uart2;
> + };
> +
> + chosen {
> + stdout-path = "serial0";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_keys_default>;
> +
> + label = "GPIO Buttons";
> +
> + button-volume-up {
> + label = "Volume Up";
> + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> + };
> +
> + usb_id: usb-id {
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&msmgpio 110 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_id_default>;
> + };
> +};
> +
> +&blsp1_uart2 {
> + status = "okay";
> +};
> +
> +&pm8916_resin {
> + status = "okay";

status is the last property

> + linux,code = <KEY_VOLUMEDOWN>;
> +};
> +
> +&pm8916_vib {
> + status = "okay";
> +};
> +
> +&pronto {
> + status = "okay";
> +};
> +
> +&sdhc_1 {
> + status = "okay";

Here as well and in all other places.


Best regards,
Krzysztof