Re: [PATCH 028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new()

From: Laurent Pinchart
Date: Sat Nov 19 2022 - 12:35:07 EST


On Fri, Nov 18, 2022 at 11:36:02PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/bridge/parade-ps8622.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 309de802863d..530ee6a19e7e 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -442,9 +442,9 @@ static const struct of_device_id ps8622_devices[] = {
> };
> MODULE_DEVICE_TABLE(of, ps8622_devices);
>
> -static int ps8622_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ps8622_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct device *dev = &client->dev;
> struct ps8622_bridge *ps8622;
> struct drm_bridge *panel_bridge;
> @@ -538,7 +538,7 @@ MODULE_DEVICE_TABLE(i2c, ps8622_i2c_table);
>
> static struct i2c_driver ps8622_driver = {
> .id_table = ps8622_i2c_table,
> - .probe = ps8622_probe,
> + .probe_new = ps8622_probe,
> .remove = ps8622_remove,
> .driver = {
> .name = "ps8622",
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart