Re: [PATCH 018/606] drm/bridge: icn6211: Convert to i2c's .probe_new()

From: Laurent Pinchart
Date: Sat Nov 19 2022 - 12:32:28 EST


On Fri, Nov 18, 2022 at 11:35:52PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index bf920c3503aa..0e37840cd7a8 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -740,8 +740,7 @@ static int chipone_dsi_probe(struct mipi_dsi_device *dsi)
> return ret;
> }
>
> -static int chipone_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int chipone_i2c_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct chipone *icn;
> @@ -796,7 +795,7 @@ static struct i2c_device_id chipone_i2c_id[] = {
> MODULE_DEVICE_TABLE(i2c, chipone_i2c_id);
>
> static struct i2c_driver chipone_i2c_driver = {
> - .probe = chipone_i2c_probe,
> + .probe_new = chipone_i2c_probe,
> .id_table = chipone_i2c_id,
> .driver = {
> .name = "chipone-icn6211-i2c",
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart