Re: [PATCH 358/606] media: i2c/ov6650: Convert to i2c's .probe_new()

From: Janusz Krzysztofik
Date: Sat Nov 19 2022 - 02:02:11 EST


Dnia piątek, 18 listopada 2022 23:41:32 CET Uwe Kleine-König pisze:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

LGTM

Acked-by: Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>


> ---
> drivers/media/i2c/ov6650.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
> index 18f041e985b7..4c0ea2ae671b 100644
> --- a/drivers/media/i2c/ov6650.c
> +++ b/drivers/media/i2c/ov6650.c
> @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
> /*
> * i2c_driver function
> */
> -static int ov6650_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int ov6650_probe(struct i2c_client *client)
> {
> struct ov6650 *priv;
> int ret;
> @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver = {
> .driver = {
> .name = "ov6650",
> },
> - .probe = ov6650_probe,
> + .probe_new = ov6650_probe,
> .remove = ov6650_remove,
> .id_table = ov6650_id,
> };
>