Re: [patch 21/33] genirq/msi: Provide msi_domain_alloc_irq_at()

From: Reinette Chatre
Date: Fri Nov 18 2022 - 18:17:35 EST


Hi Thomas,

On 11/18/2022 2:31 PM, Thomas Gleixner wrote:
> On Fri, Nov 18 2022 at 10:18, Reinette Chatre wrote:
>>> @@ -141,7 +141,7 @@ static int msi_insert_desc(struct device *dev, struct msi_desc *desc,
>>> if (ret)
>>> goto fail;
>>>
>>> - desc->msi_index = index;
>>> + desc->msi_index = index - baseidx;
>>
>> Could msi_desc->msi_index be made bigger? The hardware I am testing
>> on claims to support more IMS entries than what the u16 can
>> accommodate.
>
> Sure that's trivial. How big does it claim it is?

2048

> I assume your sequence is:
>
> pci_ims_alloc();
> request_irq(); <- This creates it
> free_irq(); <- This removes it
> pci_ims_free();
>
> Right?

No. My mistake. Sorry for the noise.

Reinette