Re: [PATCH 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl bindings

From: Krzysztof Kozlowski
Date: Fri Nov 18 2022 - 11:11:02 EST


On 16/11/2022 12:10, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:57, Abel Vesa wrote:
>> Add device tree binding Documentation details for Qualcomm SM8550
>> TLMM device
>>
>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>> ---
>> .../bindings/pinctrl/qcom,sm8550-pinctrl.yaml | 184 ++++++++++++++++++
>> 1 file changed, 184 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8550-pinctrl.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8550-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8550-pinctrl.yaml
>> new file mode 100644
>> index 000000000000..4c5a8b78315b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8550-pinctrl.yaml
>> @@ -0,0 +1,184 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,sm8550-pinctrl.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. SM8550 TLMM block
>> +
>> +maintainers:
>> + - Abel Vesa <abel.vesa@xxxxxxxxxx>
>> +
>> +description: |
>> + This binding describes the Top Level Mode Multiplexer (TLMM) block found
>> + in the SM8550 platform.
>
> Rebase on recent next and apply same changes as in 09f537065c06.
>
>> +
>> +allOf:
>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: qcom,sm8550-tlmm
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts: true
>> + interrupt-controller: true
>> + '#interrupt-cells': true
>> + gpio-controller: true
>> +
>> + gpio-reserved-ranges:
>> + minItems: 1
>> + maxItems: 105
>> +
>> + gpio-line-names:
>> + maxItems: 209
>
> You have 210 GPIOs, so maxItems: 210
>
>> +
>> + '#gpio-cells': true
>> + gpio-ranges: true
>> + wakeup-parent: true
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>
> This and required go after all properties and defs are listed.
>> +
>> +patternProperties:
>> + '-state$':
>> + oneOf:
>> + - $ref: "#/$defs/qcom-sm8550-tlmm-state"
>
> Use same quotes - either ' or "
>
>> + - patternProperties:
>> + "-pins$":
>> + $ref: "#/$defs/qcom-sm8550-tlmm-state"
>> + additionalProperties: false
>> +
>> + "^.+-hog(-[0-9]+)?$":
>> + type: object
>> + properties:
>> + gpio-hog: true
>> + gpios: true
>> + input: true
>> + output-high: true
>> + output-low: true
>> + line-name: true
>
> Keep properties sorted by name (just like gpio-hog.yaml).
>
> I wonder if we could add this to the common TLMM schema. It will appear
> in multiple places.

Answering to myself - this would require moving the 'state'
patternProperties part to the common schema, so maybe later... Looks
fine with changes about ordering.

Best regards,
Krzysztof