Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

[Bryan O'Donoghue]

On 08/11/2022 12:46, Dmitry Baryshkov wrote:
> On 08/11/2022 02:56, Bryan O'Donoghue wrote:
> > Currently we do not differentiate between the various users of the
> > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
> > compatible string but, the hardware does have some significant 
> > differences
> > in the number of clocks.
> >
> > To facilitate documenting the clocks add the following compatible strings
> >
> > - qcom,mdss-dsi-ctrl-apq8064
>
> Generic comment: I think we'd better follow the arm/qcom-soc.yaml and 
> use qcom,soc-something as compat string. This would leave us with 
> qcom,apq8064-dsi-ctrl
>
> I'm not sure if we want to follow the qcm2290 approach and encode the 
> DSI ctrl revision here (6g vs v2).

For qcm2290 I'm thinking qcm2290-dsi-ctrl - without the 6g piece.

a) Nobody is using the compat at the moment
b) I'm not sure what - if any real information the silicon version
   number conveys here.

+ Loic, Shawn

---
bod