Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio

From: Krzysztof Kozlowski
Date: Fri Nov 18 2022 - 07:38:58 EST


On 14/11/2022 10:50, Yinbo Zhu wrote:
>
>>> +
>>> + "#gpio-cells":
>>> + const: 2
>>> +
>>> + gpio-controller: true
>>> +
>>> + gpio-ranges: true
>>> +
>>> + loongson,conf_offset:
>>
>> No underscores in node names. Plus comments from Linus seem to apply
>> here as well. Drop it entirely or explain why this is not part of
>> compatible, why this is needed and why encoding programming model
>> address in DT matches the DT...
> Add it is to distinguish differnt address in different platform.
> and I had drop them and initial them in kernel driver that depend
> on diffent compatible.
>>

So if you had to drop these, please drop from the bindings.

Best regards,
Krzysztof