Re: [V4 PATCH 1/3] KVM: selftests: move common startup logic to kvm_util.c

From: Vishal Annapurve
Date: Thu Nov 17 2022 - 13:22:15 EST


On Wed, Nov 16, 2022 at 9:36 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Tue, Nov 15, 2022, Vishal Annapurve wrote:
> > Consolidate common startup logic in one place by implementing a single
> > setup function with __attribute((constructor)) for all selftests within
> > kvm_util.c.
> >
> > This allows moving logic like:
> > /* Tell stdout not to buffer its content */
> > setbuf(stdout, NULL);
> > to a single file for all selftests.
> >
> > This will also allow any required setup at entry in future to be done in
> > common main function.
> >
> > More context is discussed at:
> > https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@xxxxxxxxxx/
>
> Nit,
>
> Link: https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@xxxxxxxxxx
>
> is the the "standard" way to convey this information.

Noted.