Re: [PATCH] arm64/mm: Drop unused restore_ttbr1

From: Mark Rutland
Date: Thu Nov 17 2022 - 07:54:29 EST


On Thu, Nov 17, 2022 at 06:01:44PM +0530, Anshuman Khandual wrote:
> restore_ttbr1 procedure is not used anywhere, hence just drop it.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.

> ---
> This applies on v6.1-rc5
>
> arch/arm64/include/asm/assembler.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index e5957a53be39..f13bc52ab347 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -619,17 +619,6 @@ alternative_endif
> #endif
> .endm
>
> -/*
> - * Perform the reverse of offset_ttbr1.
> - * bic is used as it can cover the immediate value and, in future, won't need
> - * to be nop'ed out when dealing with 52-bit kernel VAs.
> - */
> - .macro restore_ttbr1, ttbr
> -#ifdef CONFIG_ARM64_VA_BITS_52
> - bic \ttbr, \ttbr, #TTBR1_BADDR_4852_OFFSET
> -#endif
> - .endm
> -
> /*
> * Arrange a physical address in a TTBR register, taking care of 52-bit
> * addresses.
> --
> 2.25.1
>