Re: [PATCH wireless] brcmfmac: fix potential memory leak in brcmf_netdev_start_xmit()

From: Zhang Changzhong
Date: Thu Nov 17 2022 - 06:05:33 EST


On 2022/11/17 18:09, Kalle Valo wrote:
> Zhang Changzhong <zhangchangzhong@xxxxxxxxxx> writes:
>
>> The brcmf_netdev_start_xmit() returns NETDEV_TX_OK without freeing skb
>> in case of pskb_expand_head() fails, add dev_kfree_skb() to fix it.
>>
>> Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
>> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
>
> I assume you have not tested this on a real device? Then it would be
> really important to add "Compile tested only" to the commit log so that
> we know it's untested.
>

OK, I'll add "Compile tested only" to the next version and other untested
patches.

Thanks,
Changzhong