Re: [PATCH v2] dmaengine: ste_dma40: use devm_request_irq to avoid missing free_irq() in error path

From: Linus Walleij
Date: Thu Nov 17 2022 - 04:07:38 EST


On Wed, Nov 16, 2022 at 8:01 AM ruanjinjie <ruanjinjie@xxxxxxxxxx> wrote:

> free_irq() is missing in some cases of error in d40_probe(), use
> devm_request_irq to fix that.
>
> Fixes: d7b7ecce4bcb ("ste_dma40: Rename a jump label in d40_probe()")
> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>
> ---
> v2:
> - use devm_request_irq instead of adding free_irq() to fix the problem.

Thanks!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij