Re: [PATCH v6 3/3] hwmon: (max6639) Change from pdata to dt configuration

From: Uwe Kleine-König
Date: Thu Nov 17 2022 - 02:45:41 EST


Hello,

On Wed, Nov 16, 2022 at 10:36:15PM +0100, Naresh Solanki wrote:
> max6639_platform_data is not used by any in-kernel driver and does not
> address the MAX6639 fans separately.
> Move to device tree configuration with explicit properties to configure
> each fan.
>
> Non-DT platform can still use this module with its default
> configuration.
>
> Signed-off-by: Marcello Sylvester Bauer <sylv@xxxxxxx>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>

What changed here since v5? Please either add a changelog below the
tripple-dash for a new revision, or make sure that all relevant people
get the cover letter.

It seems you didn't address my comments for v5 :-\

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature