Re: [PATCH 1/2] media: dt-bindings: allwinner: video-engine: Fix number of IOMMU channels

From: Samuel Holland
Date: Wed Nov 16 2022 - 18:06:29 EST


On 11/16/22 13:31, Jernej Skrabec wrote:
> Cedrus (video engine) on Allwinner H6 actually uses two IOMMU channel,
> not just one. However, Cedrus on SoCs like D1 only uses one channel.
>
> Allow up to 2 IOMMU channels.
>
> Fixes: 62a8ccf3a248 ("arm64: dts: allwinner: h6: Fix Cedrus IOMMU usage")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> ---
> .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> index 541325f900a1..257bb372d166 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> @@ -55,7 +55,7 @@ properties:
> description: Phandle to the device SRAM
>
> iommus:
> - maxItems: 1
> + maxItems: 2

You need to add minItems: 1, or else this will require two items.

Regards,
Samuel

>
> memory-region:
> maxItems: 1