Re: [PATCH v3 02/10] dm: remove free_table_devices

From: Mike Snitzer
Date: Wed Nov 16 2022 - 16:53:20 EST


On Tue, Nov 15 2022 at 9:10P -0500,
Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:

> From: Christoph Hellwig <hch@xxxxxx>
>
> free_table_devices just warns and frees all table_device structures when
> the target removal did not remove them. This should never happen, but
> if it did, just freeing the structure without deleting them from the
> list or cleaning up the resources would not help at all. So just WARN on
> a non-empty list instead.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Reviewed-by: Mike Snitzer <snitzer@xxxxxxxxxx>