Re: arch/parisc/kernel/setup.c:64 setup_cmdline() warn: inconsistent indenting

From: Helge Deller
Date: Wed Nov 16 2022 - 15:57:35 EST


On 11/16/22 18:48, kernel test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 59d0d52c30d4991ac4b329f049cc37118e00f5b0
commit: 5f7ee6e37a3cadefe45378c17c4285fa41141d92 parisc: Autodetect default output device and set console= kernel parameter
date: 10 months ago
config: parisc-randconfig-m041-20221116
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

smatch warnings:
arch/parisc/kernel/setup.c:64 setup_cmdline() warn: inconsistent indenting

Fixed now in for-next.

Thanks.
Helge


vim +64 arch/parisc/kernel/setup.c

47
48 void __init setup_cmdline(char **cmdline_p)
49 {
50 extern unsigned int boot_args[];
51 char *p;
52
53 /* Collect stuff passed in from the boot loader */
54
55 /* boot_args[0] is free-mem start, boot_args[1] is ptr to command line */
56 if (boot_args[0] < 64) {
57 /* called from hpux boot loader */
58 boot_command_line[0] = '\0';
59 } else {
60 strscpy(boot_command_line, (char *)__va(boot_args[1]),
61 COMMAND_LINE_SIZE);
62
63 /* autodetect console type (if not done by palo yet) */
> 64 p = boot_command_line;
65 if (!str_has_prefix(p, "console=") && !strstr(p, " console=")) {
66 strlcat(p, " console=", COMMAND_LINE_SIZE);
67 if (PAGE0->mem_cons.cl_class == CL_DUPLEX)
68 strlcat(p, "ttyS0", COMMAND_LINE_SIZE);
69 else
70 strlcat(p, "tty0", COMMAND_LINE_SIZE);
71 }
72