Re: [PATCH v3 1/4] dt-bindings: pwm: Add Apple PWM controller

From: Rob Herring
Date: Wed Nov 16 2022 - 15:20:52 EST


On Fri, Nov 11, 2022 at 08:33:45PM +0300, Sasha Finkelstein wrote:
> Apple SoCs such as the M1 contain a PWM controller used
> among other things to control the keyboard backlight.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@xxxxxxxxx>
> Reviewed-by: Krzyszstof Kozlowski <krzyszstof.kozlowski@xxxxxxxxxx>

I assume you got a bounce on this as you got Krzysztof's name wrong
(krzysztof.kozlowski@xxxxxxxxxx). You should have either resent this or
replied pointing out the typo.

> Acked-by: Sven Peter <sven@xxxxxxxxxxxxx>
> ---
> .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
> new file mode 100644
> index 000000000000..142157bff0cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/apple,s5l-fpwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple FPWM controller
> +
> +maintainers:
> + - asahi@xxxxxxxxxxxxxxx
> + - Sasha Finkelstein <fnkl.kernel@xxxxxxxxx>
> +
> +description: PWM controller used for keyboard backlight on ARM Macs
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t8103-fpwm
> + - apple,t6000-fpwm
> + - apple,t8112-fpwm
> + - const: apple,s5l-fpwm
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + "#pwm-cells":
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pwm@235044000 {
> + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm";
> + reg = <0x35044000 0x4000>;
> + power-domains = <&ps_fpwm1>;
> + clocks = <&clkref>;
> + #pwm-cells = <2>;
> + };
> --
> 2.38.1
>
>