Re: [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC

From: Lee Jones
Date: Wed Nov 16 2022 - 13:12:00 EST


On Fri, 04 Nov 2022, Jerome Neanne wrote:

> The TPS65219 is a power management IC PMIC designed to supply a wide
> range of SoCs in both portable and stationary applications. Any SoC can
> control TPS65219 over a standard I2C interface.
>
> It contains the following components:
> - Regulators.
> - Over Temperature warning and Shut down.
> - GPIOs
> - Multi Function Pins (MFP)
> - power-button
>
> This patch adds support for tps65219 PMIC. At this time only
> the functionalities listed below are made available:
>
> - Regulators probe and functionalities
> - warm and cold reset support
> - SW shutdown support
> - Regulator warnings via IRQs
> - Power-button via IRQ
>
> Signed-off-by: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> Acked-for-mfd-by: Lee Jones <lee@xxxxxxxxxx>
> ---
>
> Notes:
> Changes in v7:
> Lee Jones review
> - Kconfig nit: button that is
> - tps65219.c, nits: '\n' x2
> - tps65219.c, nit: { .name = "tps65219-gpios", },
> - tps65219.h, nit: Power Management IC
> - tps65219.h, rework header: struct tps65219
> - tps65219.h, remove Superflous " " /* MFD_TPS65219_H */
> - remove unused tps65219_soft_shutdown further to make W=1 check
> Biju Das review:
> - Remove all includes that are not mandatory
> - Remove container_of err check
>
> MAINTAINERS | 1 +
> drivers/mfd/Kconfig | 14 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65219.c | 299 ++++++++++++++++++++++++++++++
> include/linux/mfd/tps65219.h | 345 +++++++++++++++++++++++++++++++++++
> 5 files changed, 660 insertions(+)
> create mode 100644 drivers/mfd/tps65219.c
> create mode 100644 include/linux/mfd/tps65219.h

Applied, thanks.

--
Lee Jones [李琼斯]