Re: [PATCH v2 13/15] phy: qcom-qmp-combo: add support for updated sc8280xp binding

[Dmitry Baryshkov]

On 15/11/2022 17:40, Johan Hovold wrote:
> Add support for the new SC8280XP binding.
>
> Note that the binding does not try to describe every register subregion
> and instead the driver holds the corresponding offsets.
>
> Also note that (possibly) unlike on earlier platforms, the TX registers
> are used by both the USB and DP implementation.
>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 145 ++++++++++++++++++++--
>   1 file changed, 134 insertions(+), 11 deletions(-)

The comment regarding txa/txb vs tx/tx2 still applies.
Being a minor nit:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry