Re: [PATCH] arm64: dts: ti: k3-j721s2: Fix the interrupt ranges property for main & wkup gpio intr

From: Vaishnav Achath
Date: Wed Nov 16 2022 - 04:16:07 EST




On 22/09/22 12:59, Keerthy wrote:
> The parent's input irq number is wrongly subtracted with 32 instead of
> using the exact numbers in:
>
> https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j721s2/interrupt_cfg.html
>
> The GPIO interrupts are not working because of that. The toggling works
> fine but interrupts are not firing. Fix the parent's input irq that
> specifies the base for parent irq.
>
> Tested for MAIN_GPIO0_6 interrupt on the j721s2 EVM.
>
> Fixes: b8545f9d3a542 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> ---
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 34e7d577ae13..c89f28235812 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -60,7 +60,7 @@
> #interrupt-cells = <1>;
> ti,sci = <&sms>;
> ti,sci-dev-id = <148>;
> - ti,interrupt-ranges = <8 360 56>;
> + ti,interrupt-ranges = <8 392 56>;
> };
>
> main_pmx0: pinctrl@11c000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index 4d1bfabd1313..f0644851602c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -65,7 +65,7 @@
> #interrupt-cells = <1>;
> ti,sci = <&sms>;
> ti,sci-dev-id = <125>;
> - ti,interrupt-ranges = <16 928 16>;
> + ti,interrupt-ranges = <16 960 16>;

Reviewed-by: Vaishnav Achath <vaishnav.a@xxxxxx>

> };
>
> mcu_conf: syscon@40f00000 {

--
Regards,
Vaishnav