Re: [PATCH 1/2] dtbindings: clock: Add bindings for Renesas PhiClock

From: Krzysztof Kozlowski
Date: Wed Nov 16 2022 - 03:20:59 EST


On 15/11/2022 20:26, Alex Helms wrote:
> Add dt bindings for the Renesas PhiClock clock generator.
>

Subject: drop second, redundant "bindings"

> Signed-off-by: Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> ---
> .../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml
> new file mode 100644
> index 000000000..2b36534d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml

Filename based on compatible.

> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/renesas,phiclock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas PhiClock Clock Generator Device Tree Bindings

Drop "Device Tree Bindings"

> +
> +maintainers:
> + - Alex Helms <alexander.helms.jy@xxxxxxxxxxx>
> +
> +description: |
> + The Renesas PhiClock is a programmable I2C clock generator that provides
> + 1 reference output and 2 clock outputs.
> +
> + The driver supports spread spectrum but only if all configurations use the

Driver as in Linux driver? Drop entire paragraph. Bindings are about
hardware, not driver.

> + same spread spectrum parameters. If your configuration uses spread spectrum,
> + you must include renesas,ss-amount-percent, renesas,ss-modulation-hz, and
> + renesas,ss-direction in the device tree.
> +
> +properties:

compatible goes always first. Start your schema from example-schema.yaml.

> + '#clock-cells':
> + const: 1
> +
> + clock-names:
> + items:
> + - const: xin-clkin

Just "xin" or entirely drop.

> +
> + clocks:
> + const: 1
> +
> + compatible:
> + enum:
> + - renesas,9fgv1006
> +
> + reg:
> + maxItems: 1
> +
> + renesas,ss-amount-percent:
> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%.

What? If this is percent then it cannot be hundreds of percent. Percent
is percent. Use appropriate units.
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> + minimum: 0
> + maximum: 500
> +
> + renesas,ss-modulation-hz:
> + description: Spread spectrum modulation rate in Hz
> + minimum: 30000
> + maximum: 63000
> +
> + renesas,ss-direction:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Spread spectrum direction
> + enum: [ down, center ]
> +
> +required:
> + - clock-names
> + - '#clock-cells'
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + ref25: ref25m {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };

Drop, it's obvious, isn't it?

> +

Best regards,
Krzysztof