Re: [PATCH 2/4] pwm: Reduce time the pwm_lock mutex is held in pwmchip_add()

From: Andy Shevchenko
Date: Wed Nov 16 2022 - 03:14:11 EST


On Tue, Nov 15, 2022 at 10:15:13PM +0100, Uwe Kleine-König wrote:
> This simplifies error handling as the need for goto error handling goes
> away and at the end of the function the code can be simplified as this
> code isn't used in the error case any more.

...

> + mutex_unlock(&pwm_lock);
>
> if (IS_ENABLED(CONFIG_OF))
> of_pwmchip_add(chip);

Why calling this without a lock is not a problem? Commit message doesn't share
a bit about this change.

> -out:
> - mutex_unlock(&pwm_lock);

--
With Best Regards,
Andy Shevchenko