Re: [net-next][PATCH] dsa: lan9303: Changed ethtool stats

From: Saeed Mahameed
Date: Wed Nov 16 2022 - 00:00:23 EST


On 14 Nov 22:11, Andrew Lunn wrote:
Hi Jerry

Added a version number to the module.

Don't bother, it is useless. A driver is not standalone, it depends on
the rest of the kernel around it. Somebody telling you version 1.1 is
broken is no help, you have no idea what version of mainline is around
it, or if it is a backport in a vendor kernel along with 1000 other
patches.

And as a general comment, one patch should do one thing. Please break
this up into a patchset.

Andrew

Just drop the MODULE_VERSION

it's getting removed from all modules, Gregkh is always asking to remove
them. https://lore.kernel.org/lkml/20210528092242.51104-2-eli.billauer@xxxxxxxxx/