Re: [PATCH 1/2] scsi: Fix get_user() in call sg_scsi_ioctl()

[Dave Hansen]

On 11/15/22 16:43, Kirill A. Shutemov wrote:
> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.
> 
> Cast it explicitly to 'unsigned char __user *'. It matches current
> behaviour.
> 
> This is preparation for fixing sparse warnings caused by Linear Address
> Masking patchset.

What's the side-effect if this isn't applied?  Is it worse than sparse
warnings?