Re: [PATCH v3 2/3] can: etas_es58x: export firmware, bootloader and hardware versions in sysfs

[Saeed Mahameed]

On 13 Nov 13:01, Vincent Mailhol wrote:
> ES58x devices report below information in their usb product info
> string:
>
>  * the firmware version
>  * the bootloader version
>  * the hardware revision
>
> Parse this string, store the results in struct es58x_dev and create
> three new sysfs entries.

will this be the /sys/class/net/XXX sysfs  ?

We try to avoid adding device specific entries in there,

Couldn't you just squeeze the firmware and hw version into the 
ethtool->drvinfo->fw_version

something like: 
fw_version: %3u.%3u.%3u (%c.%3u.%3u)

and bootloader into ethtool->drvinfo->erom_version: 
 * @erom_version: Expansion ROM version string; may be an empty string