Re: [PATCH] cacheinfo: Decrement refcount in cache_setup_of_node()

From: Pierre Gondois
Date: Tue Nov 15 2022 - 17:10:32 EST




On 11/15/22 20:30, Marek Szyprowski wrote:
Hi Geert,

On 15.11.2022 14:06, Geert Uytterhoeven wrote:
On Wed, Oct 26, 2022 at 9:03 PM Pierre Gondois <pierre.gondois@xxxxxxx> wrote:
Refcounts to DT nodes are only incremented in the function
and never decremented. Decrease the refcounts when necessary.

Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx>
Thanks for your patch, which is now commit 3da72e18371c41a6
("cacheinfo: Decrement refcount in cache_setup_of_node()") in
driver-core-next.

I have bisected a refcount underflow during s2ram to this commit:

Similar issue can be reproduced with qemu/arm64 'virt' machine during boot:


Hello Geert, Marek,

Thanks for reporting the issue. The patch at:
https://lore.kernel.org/all/20221115220520.2076189-1-pierre.gondois@xxxxxxx/
should fix it,

Regards,
Pierre