Re: [PATCH v2 1/2] pwm: core: Refactor pwmchip_add() to avoid extra checks

From: Uwe Kleine-König
Date: Tue Nov 15 2022 - 15:24:38 EST

Next message: Gustavo A. R. Silva: "[PATCH][next] scsi: bfa: Replace one-element array with flexible-array member"
Previous message: Hamza Mahfooz: "[PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support"
In reply to: Andy Shevchenko: "[PATCH v2 2/2] pwm: core: Remove S_IFREG from debugfs_create_file()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello,

On Mon, Nov 14, 2022 at 07:00:04PM +0200, Andy Shevchenko wrote:
> When we already know that everything is fine there is no need
> to use ret variable. Refactor code accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

The patch is correct (i.e. doesn't change the semantic of the function).

But I think there is some more potential to clean up than it used here.
I will send out a series that I like better than this patch.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature

Next message: Gustavo A. R. Silva: "[PATCH][next] scsi: bfa: Replace one-element array with flexible-array member"
Previous message: Hamza Mahfooz: "[PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support"
In reply to: Andy Shevchenko: "[PATCH v2 2/2] pwm: core: Remove S_IFREG from debugfs_create_file()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]