Re: [PATCH] coredump: Fix build error for ‘dump_emit_page’ defined but not used

From: Chaitanya Kulkarni
Date: Tue Nov 15 2022 - 14:35:26 EST


On 11/14/22 20:04, Li Hua wrote:
> If CONFIG_ELF_CORE is not set:
> fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
> static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> ^~~~~~~~~~~~~~
>
> Fix this by adding the missing CONFIG_ELF_CORE for dump_emit_page.
>
> Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
> Signed-off-by: Li Hua <hucool.lihua@xxxxxxxxxx>
> ---


Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck