Re: [PATCH v2 6/7] ARM: dts: r9a06g032: Add the USBF controller node

From: Krzysztof Kozlowski
Date: Tue Nov 15 2022 - 09:59:09 EST


On 15/11/2022 15:11, Geert Uytterhoeven wrote:
>>> + udc: usb@4001e000 {
>>> + compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf";
>>> + reg = <0x4001e000 0x2000>;
>>> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&sysctrl R9A06G032_HCLK_USBF>,
>>> + <&sysctrl R9A06G032_HCLK_USBPM>;
>>> + clock-names = "hclkf", "hclkpm";
>>> + power-domains = <&sysctrl>;
>>> + status = "disabled";
>>
>> If you provided all resources (clocks, power domains etc), why disabling it?
>
> Doesn't this depend on wiring on the board, and providing pin control
> in the board DTS?
>

Yes, that could be the reason, so if this was the intention, it's fine.

Best regards,
Krzysztof