Re: [PATCH v3 01/13] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support

[Jon Hunter]

On 14/11/2022 12:40, Wayne Chang wrote:
> Extend the Tegra XUSB controller device tree binding with Tegra234
> support.
>
> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:address the issue on phy-names property
>   .../bindings/usb/nvidia,tegra-xudc.yaml       | 24 ++++++++++++-------
>   1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> index fd6e7c81426e..52488a731c4e 100644
> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> @@ -22,6 +22,7 @@ properties:
>             - nvidia,tegra210-xudc # For Tegra210
>             - nvidia,tegra186-xudc # For Tegra186
>             - nvidia,tegra194-xudc # For Tegra194
> +          - nvidia,tegra234-xudc # For Tegra234
>   
>     reg:
>       minItems: 2
> @@ -90,21 +91,27 @@ properties:
>   
>     phys:
>       minItems: 1
> +    maxItems: 8
>       description:
>         Must contain an entry for each entry in phy-names.
>         See ../phy/phy-bindings.txt for details.
>   
>     phy-names:
>       minItems: 1
> +    maxItems: 8
>       items:
> -      - const: usb2-0
> -      - const: usb2-1
> -      - const: usb2-2
> -      - const: usb2-3
> -      - const: usb3-0
> -      - const: usb3-1
> -      - const: usb3-2
> -      - const: usb3-3
> +      enum:
> +        - usb2-0
> +        - usb2-1
> +        - usb2-2
> +        - usb2-3
> +        - usb3-0
> +        - usb3-1
> +        - usb3-2
> +        - usb3-3
> +
> +  dma-coherent:
> +    type: boolean
>   
>     avddio-usb-supply:
>       description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> @@ -153,6 +160,7 @@ allOf:
>               enum:
>                 - nvidia,tegra186-xudc
>                 - nvidia,tegra194-xudc
> +              - nvidia,tegra234-xudc
>       then:
>         properties:
>           reg:


Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks
Jon

--
nvpublic