Re: [PATCH v2 8/8] dt-bindings: iommu: qcom,iommu: Document MSM8976 compatible

[AngeloGioacchino Del Regno]

Il 14/11/22 09:22, Krzysztof Kozlowski ha scritto:
> On 11/11/2022 15:59, AngeloGioacchino Del Regno wrote:
> > Add "qcom,msm8976-iommu" to support IOMMUs on this SoC.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/iommu/qcom,iommu.txt | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> > index b762772f80e7..b7a5822ac00d 100644
> > --- a/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> > +++ b/Documentation/devicetree/bindings/iommu/qcom,iommu.txt
> > @@ -9,7 +9,8 @@ to non-secure vs secure interrupt line.
> >   
> >   - compatible       : Should be one of:
> >   
> > -                        "qcom,msm8916-iommu"
> > +                        - "qcom,msm8916-iommu"
> > +                        - "qcom,msm8976-iommu"
>
> Shouldn't the new compatible be followed by IOMMU v2, not v1?

Yes, effectively, it should.

I'll have to partially rewrite also commit 6/8, so I'll have to drop your
Acked-by tag on both....
Will send a new one shortly.

Cheers,
Angelo