Re: [PATCH v2 15/15] dt-bindings: arm64: dts: mediatek: Add mt8365-evk board

From: Krzysztof Kozlowski
Date: Tue Nov 15 2022 - 04:48:03 EST


On 15/11/2022 03:54, Bernhard Rosenkränzer wrote:
> Add bindings for the Mediatek mt8365-evk board.
>
> Signed-off-by: Bernhard Rosenkränzer <bero@xxxxxxxxxxxx>

You document a patch after using a compatible - that's broken order.

> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index d76ce4c3819db..6781fcdb9fe69 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -246,6 +246,10 @@ properties:
> - enum:
> - mediatek,mt8516-pumpkin
> - const: mediatek,mt8516
> + - items:
> + - enum:
> + - mediatek,mt8365-evk
> + - const: mediatek, mt8365

No spaces in compatibles.

Best regards,
Krzysztof