Re: [PATCH v2 0/5] Add kprobe and kretprobe support for LoongArch

From: Tiezhu Yang
Date: Tue Nov 15 2022 - 03:44:24 EST




On 11/14/2022 12:31 PM, Huacai Chen wrote:
Hi, Tiezhu,

Thanks for your patches, however,
1, You should rebase your code, since some functions such as
is_pc_insn is provided in the github's loongarch-next branch;
2, Your code may have some problems about preemption, you can do
something like this commit [1];
3, I don't think Kprobe should be enabled by default, distribution
configs can enable it if needed.

[1] https://github.com/loongson/linux/commit/023d5412ab5c154b87d57d70d465a4243df53717


OK, thank you, I will rebase and address the review comments,
and then send v3 later.

Thanks,
Tiezhu