Re: [PATCH v2 4/4] arm64: dts: ti: Add support for J784S4 EVM board

[Nishanth Menon]

On 17:48-20221111, Apurva Nandan wrote:
> 
[...]

> > > Schematics: https://www.ti.com/lit/zip/sprr458


> > > 
> > > Signed-off-by: Hari Nagalla <hnagalla@xxxxxx>
> > > Signed-off-by: Apurva Nandan <a-nandan@xxxxxx>
> > > Signed-off-by: Nishanth Menon <nm@xxxxxx>
> > > Signed-off-by: Matt Ranostay <mranostay@xxxxxx>
> > > Signed-off-by: Rahul T R <r-ravikumar@xxxxxx>
> > > Signed-off-by: Suman Anna <s-anna@xxxxxx>
> > > Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>
> > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

Uggh - too many Signed-off-by -> Can we either trim this down or use
Co-developed-by ?

The last of the SoB should be yours as you are handing the patch over.
> > > ---
> > >    arch/arm64/boot/dts/ti/Makefile          |   2 +
> > >    arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 199 +++++++++++++++++++++++
> > >    2 files changed, 201 insertions(+)
> > >    create mode 100644 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> > > index 02e5d80344d0..6381c458738a 100644
> > > --- a/arch/arm64/boot/dts/ti/Makefile
> > > +++ b/arch/arm64/boot/dts/ti/Makefile
> > > @@ -19,6 +19,8 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb
> > >    dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb

One EoL here please? helps keeps the dtbs grouped.

> > > +dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb
> > > +
> > >    dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb
> > >    dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb
> > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > > new file mode 100644
> > > index 000000000000..bf2f2dfb7658
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > > @@ -0,0 +1,199 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> > > + *
> > > + * Common Processor Board: https://www.ti.com/tool/J721EXCPXEVM
> > This doesn't seem to be the right EVM, I'd just drop this link.

Please use the proper link -> I think it is in commit message.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D