Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code

From: Chaitanya Kulkarni
Date: Mon Nov 14 2022 - 22:49:44 EST


On 11/14/22 16:40, Bart Van Assche wrote:
> On 10/5/22 20:18, Chaitanya Kulkarni wrote:
>> Insteasd of using the hardcoded value use meaningful macro for tag
>
> Insteasd -> Instead?
>
>> available value of -1U in get_tag() and __alloc_cmd().
>>
>> While at it return early on error to get rid of the extra indentation
>> in __alloc_cmd().
>
> Thanks,
>
> Bart.
>

thanks for your comment Bart, I'll send out V3 with fixes..

-ck