Re: [PATCH v3] tcp: Add listening address to SYN flood message

[Stephen Hemminger]

On Mon, 14 Nov 2022 09:31:38 -0800
Eric Dumazet <edumazet@xxxxxxxxxx> wrote:

> On Sun, Nov 13, 2022 at 5:00 PM Jamie Bainbridge
> <jamie.bainbridge@xxxxxxxxx> wrote:
> >
> > The SYN flood message prints the listening port number, but with many
> > processes bound to the same port on different IPs, it's impossible to
> > tell which socket is the problem.
> >
> > Add the listen IP address to the SYN flood message.
> >
> > For IPv6 use "[IP]:port" as per RFC-5952 and to provide ease of
> > copy-paste to "ss" filters. For IPv4 use "IP:port" to match.
> >
> > Each protcol's "any" address and a host address now look like:
> >
> >  Possible SYN flooding on port 0.0.0.0:9001.
> >  Possible SYN flooding on port 127.0.0.1:9001.
> >  Possible SYN flooding on port [::]:9001.
> >  Possible SYN flooding on port [fc00::1]:9001.
> >
> > Signed-off-by: Jamie Bainbridge <jamie.bainbridge@xxxxxxxxx>
> > ---  
> 
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks for cleaning this up.
Reviewed-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>