Re: [PATCH] zram: explicitly limit prio_max for static analyzers

From: Andrew Morton
Date: Mon Nov 14 2022 - 19:42:16 EST


On Mon, 14 Nov 2022 11:14:20 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:

> Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
> ---
> drivers/block/zram/zram_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 9d33801e8ba8..e67a124f2e88 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1706,6 +1706,7 @@ static int zram_recompress(struct zram *zram, u32 index, struct page *page,
> * Iterate the secondary comp algorithms list (in order of priority)
> * and try to recompress the page.
> */
> + prio_max = min(prio_max, ZRAM_MAX_COMPS);
> for (; prio < prio_max; prio++) {
> if (!zram->comps[prio])
> continue;

I'll queue this as a fix to "zram: introduce recompress sysfs knob".

What's it do? A little changelog would be nice, or at least a link to
the coverity report?