Re: [net-next][PATCH] dsa: lan9303: Changed ethtool stats

From: Andrew Lunn
Date: Mon Nov 14 2022 - 16:12:32 EST


Hi Jerry

> Added a version number to the module.

Don't bother, it is useless. A driver is not standalone, it depends on
the rest of the kernel around it. Somebody telling you version 1.1 is
broken is no help, you have no idea what version of mainline is around
it, or if it is a backport in a vendor kernel along with 1000 other
patches.

And as a general comment, one patch should do one thing. Please break
this up into a patchset.

Andrew