Re: [PATCH bpf-next 1/2] bpftool: Use strcmp() instead of is_prefix() to check parameters

From: Quentin Monnet
Date: Mon Nov 14 2022 - 15:45:40 EST


On Mon, 14 Nov 2022 at 17:25, <sdf@xxxxxxxxxx> wrote:
>
> On 11/14, Tiezhu Yang wrote:
> > In the current code, the parameters check of bpftool seems not correct,
> > for example, "bpftool batch file FILE" is the expected command format,
> > but "bpftool b f FILE" is recognized as valid, so use strcmp() instead
> > of is_prefix() to check parameters.
>
> That's by design and is similar to what iproute2 commands are doing.

Agreed with Stanislav, all bpftool commands support argument prefixing
and it's helpful, I see no reason to remove it for the batch command.
But thanks anyway for reporting