Re: [PATCH] KVM: x86/xen: Make number of event channels defines less magical

From: David Woodhouse
Date: Mon Nov 14 2022 - 13:39:28 EST


On Mon, 2022-11-14 at 18:16 +0000, Sean Christopherson wrote:
> Use BITS_PER_BYTE and sizeof_field() to compute the number of Xen event
> channels. The compat version at least uses sizeof_field(), but the
> regular version open codes sizeof_field(), BITS_PER_BYTE, and combines
> literals in the process, which makes it far too difficult to understand
> relatively straightforward code.
>
> No functional change intended.

Slightly dubious about changing the regular one, since that's just
imported directly from Xen public header files.

Attachment: smime.p7s
Description: S/MIME cryptographic signature