Re: [PATCH v1 07/28] rust: macros: take string literals in `module!`

From: Wei Liu
Date: Mon Nov 14 2022 - 09:47:18 EST


On Thu, Nov 10, 2022 at 05:41:19PM +0100, Miguel Ojeda wrote:
> From: Gary Guo <gary@xxxxxxxxxxx>
>
> Instead of taking binary string literals, take string ones instead,
> making it easier for users to define a module, i.e. instead of
> calling `module!` like:
>
> module! {
> ...
> name: b"rust_minimal",
> ...
> }
>
> now it is called as:
>
> module! {
> ...
> name: "rust_minimal",
> ...
> }
>
> Module names, aliases and license strings are restricted to
> ASCII only. However, the author and the description allows UTF-8.

What's the rationale behind allowing UTF-8? Why not stick with ASCII
only?

Thanks,
Wei.